Use SensorDeviceClass.UPTIME in WLED#169708
Open
mik-laj wants to merge 1 commit intohome-assistant:devfrom
Open
Use SensorDeviceClass.UPTIME in WLED#169708mik-laj wants to merge 1 commit intohome-assistant:devfrom
mik-laj wants to merge 1 commit intohome-assistant:devfrom
Conversation
Contributor
|
Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WLED integration to represent its uptime sensor with Home Assistant’s newer SensorDeviceClass.UPTIME instead of TIMESTAMP, aligning WLED with the newer sensor semantics in core.
Changes:
- Switch the WLED uptime sensor from
SensorDeviceClass.TIMESTAMPtoSensorDeviceClass.UPTIME. - Remove the integration-specific uptime translation string so the sensor can use the generic device-class naming.
- Update the WLED sensor snapshot to reflect the new device class.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/wled/sensor.py |
Changes the uptime sensor to use the new uptime device class. |
homeassistant/components/wled/strings.json |
Removes the now-unneeded WLED-specific uptime entity name translation. |
tests/components/wled/snapshots/test_sensor.ambr |
Updates snapshot expectations for the new device class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Use new UPTIME sensor class in WLED
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: